Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

dock config #15

Closed
wants to merge 1 commit into from
Closed

dock config #15

wants to merge 1 commit into from

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Nov 21, 2019

This creates a dock config that does the same thing as opening a terminal and dragging it to the bottom dock.

terminus1

pane.addItem(view, { index: pane.getItems().length })
pane.activateItem(view)

view.focus()
Copy link
Member Author

@UziTech UziTech Nov 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I basically copied the onDropTabBar method. This would obviously need to be refactored.

@UziTech
Copy link
Member Author

UziTech commented Nov 21, 2019

This seams like the simplest solution. Everything will work the exact same as creating a new terminal then dragging it to the bottom pane. With this implementation we could also change the checkbox to a drop down and let people choose to open it be default in the right, left, or center dock as well.

@the-j0k3r the-j0k3r added the enhancement ⚙️ New feature or request label Nov 21, 2019
@UziTech UziTech closed this Nov 22, 2019
@the-j0k3r
Copy link
Member

Why was this closed exactly? Seemed like a good idea.

@UziTech
Copy link
Member Author

UziTech commented Mar 22, 2021

this was supposed to be added to #14. It still has a few issues but I didn't have time to fix them. If you want to reopen and continue working on it you can.

This was really just a proof of concept.

@the-j0k3r
Copy link
Member

I think something like this would be ideal to get users started on opening terminal on a dock directly rather than the drag&drop which is not immediately obvious.

#14 is stalled, who knows what @akonwi (ping) plans are for that, but this seems a simpler way to implement this.

I need to find time to try a couple of things on terminus, thats sure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement ⚙️ New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants